fix(core): properly handle joining K8s api server url and path

garden-service/package.json

@@ -87,6 +87,7 @@
     "p-retry": "^4.1.0",
     "path-is-inside": "^1.0.2",
     "pluralize": "^8.0.0",
+    "proper-url-join": "^2.0.1",
     "request": "^2.88.0",
     "request-promise": "^4.2.4",
     "source-map-support": "^0.5.12",

garden-service/src/plugins/kubernetes/api.ts

@@ -9,7 +9,6 @@
 // No idea why tslint complains over this line
 // tslint:disable-next-line:no-unused
 import { IncomingMessage } from "http"
-import { resolve } from "url"
 import {
   KubeConfig,
   V1Secret,
@@ -37,6 +36,7 @@ import { GardenBaseError, RuntimeError, ConfigurationError } from "../../excepti
 import { KubernetesResource, KubernetesServerResource, KubernetesServerList } from "./types"
 import { LogEntry } from "../../logger/log-entry"
 import { kubectl } from "./kubectl"
+import { urlJoin } from "../../util/string"
 
 interface ApiGroupMap {
   [groupVersion: string]: V1APIGroup
@@ -261,7 +261,7 @@ export class KubeApi {
 
   async request(log: LogEntry, path: string, opts: Omit<request.OptionsWithUrl, "url"> = {}): Promise<any> {
     const baseUrl = this.config.getCurrentCluster()!.server
-    const url = resolve(baseUrl, path)
+    const url = urlJoin(baseUrl, path)
 
     // set some default values
     const requestOpts = {

garden-service/src/util/string.ts

@@ -8,11 +8,13 @@
 
 import _dedent = require("dedent")
 import _deline = require("deline")
+import _urlJoin = require("proper-url-join")
 
 // Exporting these here for convenience and ease of imports (otherwise we need to require modules instead of using
 // the import syntax, and it for some reason doesn't play nice with IDEs).
 export const dedent = _dedent
 export const deline = _deline
+export const urlJoin = _urlJoin as (...args: string[]) => string
 
 const gardenAnnotationPrefix = "garden.io/"