fix(k8s): avoid "no deployed releases" errors after Helm install fail…

…ure (#1046)
garden-io · Jul 30, 2019 · 87dc922 · 87dc922
1 parent 514f9f5
commit 87dc922
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/garden-service/src/plugins/kubernetes/helm/deployment.ts b/garden-service/src/plugins/kubernetes/helm/deployment.ts
@@ -59,6 +59,9 @@ export async function deployService(
       "--name", releaseName,
       "--namespace", namespace,
       "--values", valuesPath,
+      // Make sure chart gets purged if it fails to install
+      "--atomic",
+      "--timeout", "600",
     ]
     if (force) {
       installArgs.push("--replace")

diff --git a/garden-service/src/plugins/kubernetes/helm/helm-cli.ts b/garden-service/src/plugins/kubernetes/helm/helm-cli.ts
@@ -49,5 +49,7 @@ export async function helm(namespace: string, context: string, log: LogEntry, ..
   return helmCmd.stdout({
     log,
     args,
+    // Helm itself will time out pretty reliably, so we shouldn't time out early on our side.
+    timeout: 3600,
   })
 }