fix(template): allow empty string as a valid arg of isEmpty helper

test: empty strings
garden-io · Jul 12, 2023 · 66458a9 · 66458a9
1 parent 05d1dac
commit 66458a9
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/core/src/template-string/functions.ts b/core/src/template-string/functions.ts
@@ -133,7 +133,10 @@ const helperFunctionSpecs: TemplateHelperFunction[] = [
     name: "isEmpty",
     description: "Returns true if the given value is an empty string, object, array, null or undefined.",
     arguments: {
-      value: joi.alternatives(joi.object(), joi.array(), joi.string()).allow(null).description("The value to check."),
+      value: joi
+        .alternatives(joi.object(), joi.array(), joi.string().allow(""))
+        .allow(null)
+        .description("The value to check."),
     },
     outputSchema: joi.boolean(),
     exampleArguments: [

diff --git a/core/test/unit/src/template-string.ts b/core/test/unit/src/template-string.ts
@@ -1209,6 +1209,18 @@ describe("resolveTemplateString", async () => {
           expect(res).to.be.true
         })
       })
+
+      context("allows empty strings", () => {
+        it("resolves an empty string as 'true'", () => {
+          const res = resolveTemplateString("${isEmpty('')}", new TestContext({}))
+          expect(res).to.be.true
+        })
+
+        it("resolves a reference to an empty string as 'true'", () => {
+          const res = resolveTemplateString("${isEmpty(a)}", new TestContext({ a: "" }))
+          expect(res).to.be.true
+        })
+      })
     })
 
     context("slice", () => {