Skip to content

Commit

Permalink
fix(k8s): revert removal of -i flag on kubectl run commands
Browse files Browse the repository at this point in the history
This is necessary to attach and get log output. The change caused all
tests to appear to be successful, among other issues.
  • Loading branch information
edvald committed Dec 10, 2018
1 parent 766e60e commit 663deea
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion garden-service/src/plugins/kubernetes/actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,13 @@ export async function runModule(
"--restart=Never",
"--command",
"--quiet",
"--rm",
// Need to attach to get the log output and exit code.
"-i",
]

if (interactive) {
opts.push("--rm", "-it")
opts.push("--tty")
}

const kubecmd = [
Expand Down

0 comments on commit 663deea

Please sign in to comment.