Skip to content

Commit

Permalink
fix(core): fix concurrency bug in task graph
Browse files Browse the repository at this point in the history
This fixes a race condition discovered in the recently introduced
batch-oriented concurrency changes to the task graph.

Here, we store each task node's original dependencies directly on the
node itself, and do away with the `taskDependencyCache` that was
previously used (and seemed to be the cause of the race condition).

We used the opportunity to do some refactoring and cleaning up in the
`TaskGraph` class while we were at it.
  • Loading branch information
thsig authored and edvald committed Feb 14, 2020
1 parent 0409e68 commit 500ccc2
Show file tree
Hide file tree
Showing 3 changed files with 147 additions and 145 deletions.
2 changes: 1 addition & 1 deletion examples/vote-helm/garden.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ providers:
context: gke_garden-dev-200012_europe-west1-b_garden-dev-1
namespace: vote-helm-testing-${local.env.CIRCLE_BUILD_NUM || local.username}
defaultHostname: vote-helm-testing.dev-1.sys.garden
buildMode: cluster-docker
buildMode: cluster-docker
Loading

0 comments on commit 500ccc2

Please sign in to comment.