Skip to content

Commit

Permalink
fix(task-graph): ensure graph node keys and event payload keys match
Browse files Browse the repository at this point in the history
In the dashboard, we match the keys emitted with the event payload
against the node keys returned by the get graph command.

This commit adds a generic makeBaseKey function that both the Task
classes and the config graph render function use.

Previously we emitted the task key, as opposed to just the base key.
  • Loading branch information
eysi09 authored and thsig committed Apr 23, 2019
1 parent cb39a5f commit 47e84b4
Show file tree
Hide file tree
Showing 17 changed files with 178 additions and 103 deletions.
82 changes: 60 additions & 22 deletions dashboard/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion dashboard/src/api/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,12 @@ export interface FetchConfigResponse {
moduleConfigs: ModuleConfig[]
}

export type RenderedNode = { type: RenderedNodeType, name: string }
export type RenderedNode = {
type: RenderedNodeType,
name: string,
key: string,
moduleName: string,
}

export type RenderedNodeType = "build" | "deploy" | "run" | "test" | "push" | "publish"

Expand Down
Loading

0 comments on commit 47e84b4

Please sign in to comment.