Skip to content

Commit

Permalink
fix(k8s): kubernetes dashboard wasn't showing up in dashboard
Browse files Browse the repository at this point in the history
  • Loading branch information
edvald committed Feb 13, 2019
1 parent d02851e commit 2b76841
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
4 changes: 2 additions & 2 deletions garden-service/src/plugins/kubernetes/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export async function getLocalEnvironmentStatus({ ctx, log }: GetEnvironmentStat

const dashboardStatus = sysStatus.services["kubernetes-dashboard"]
const dashboardServiceResource = find(
(dashboardStatus.detail || {}).remoteObjects,
(dashboardStatus.detail || {}).remoteObjects || [],
o => o.kind === "Service",
)

Expand All @@ -154,7 +154,7 @@ export async function getLocalEnvironmentStatus({ ctx, log }: GetEnvironmentStat
dashboardPages.push({
title: "Kubernetes",
description: "The standard Kubernetes dashboard for this project",
url: `https://${defaultHostname}:${dashboardPort}/#!/workload?namespace=${namespace}`,
url: `http://${defaultHostname}:${dashboardPort}/#!/workload?namespace=${namespace}`,
newWindow: true,
})
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@ module:
name: kubernetes-dashboard
type: helm
chart: stable/kubernetes-dashboard
version: 0.9.0
version: 1.2.0
values:
# The dashboard currently needs to be exposed directly, because it does its own SSL termination.
service.type: NodePort
fullnameOverride: kubernetes-dashboard
service:
type: NodePort
# This is only okay because it's just used for the local-kubernetes plugin.
# Don't use this config for remote clusters!
enableInsecureLogin: true
enableSkipLogin: true

0 comments on commit 2b76841

Please sign in to comment.