Skip to content

Commit

Permalink
fix(k8s): remove unnecessary build step for kubernetes modules
Browse files Browse the repository at this point in the history
  • Loading branch information
edvald authored and thsig committed Jun 7, 2021
1 parent 9c9cad4 commit 26d4d12
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions core/src/plugins/kubernetes/kubernetes-module/handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { cloneDeep, partition, set, uniq } from "lodash"
import { LogEntry } from "../../../logger/log-entry"
import { PluginContext } from "../../../plugin-context"
import { NamespaceStatus } from "../../../types/plugin/base"
import { BuildModuleParams, BuildResult } from "../../../types/plugin/module/build"
import { ModuleAndRuntimeActionHandlers } from "../../../types/plugin/plugin"
import { DeleteServiceParams } from "../../../types/plugin/service/deleteService"
import { DeployServiceParams } from "../../../types/plugin/service/deployService"
Expand All @@ -37,14 +36,13 @@ import { getTaskResult } from "../task-results"
import { getTestResult } from "../test-results"
import { BaseResource, KubernetesResource, KubernetesServerResource } from "../types"
import { findServiceResource, getServiceResourceSpec } from "../util"
import { gardenNamespaceAnnotationValue, getManifests, readManifests } from "./common"
import { gardenNamespaceAnnotationValue, getManifests } from "./common"
import { configureKubernetesModule, KubernetesModule, KubernetesService } from "./config"
import { execInKubernetesService } from "./exec"
import { runKubernetesTask } from "./run"
import { testKubernetesModule } from "./test"

export const kubernetesHandlers: Partial<ModuleAndRuntimeActionHandlers<KubernetesModule>> = {
build,
configure: configureKubernetesModule,
deleteService,
execInService: execInKubernetesService,
Expand All @@ -65,12 +63,6 @@ interface KubernetesStatusDetail {

export type KubernetesServiceStatus = ServiceStatus<KubernetesStatusDetail>

async function build({ ctx, module, log }: BuildModuleParams<KubernetesModule>): Promise<BuildResult> {
// Get the manifests here, just to validate that the files are there and are valid YAML
await readManifests(ctx, module, log)
return { fresh: true }
}

export async function getKubernetesServiceStatus({
ctx,
module,
Expand Down

0 comments on commit 26d4d12

Please sign in to comment.