From 18e04859f6ba4bf7bf64eb42104b2698ae871ab0 Mon Sep 17 00:00:00 2001 From: Jon Edvald Date: Sun, 28 Apr 2019 13:52:06 -0700 Subject: [PATCH] improvement(tasks): minor logging improvements --- garden-service/src/tasks/build.ts | 2 +- garden-service/src/tasks/push.ts | 4 +++- garden-service/src/util/validate-dependencies.ts | 6 +++++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/garden-service/src/tasks/build.ts b/garden-service/src/tasks/build.ts index 2728349d10..4da586d0d7 100644 --- a/garden-service/src/tasks/build.ts +++ b/garden-service/src/tasks/build.ts @@ -69,7 +69,7 @@ export class BuildTask extends BaseTask { const log = this.log.info({ section: this.getName(), - msg: `Syncing sources...`, + msg: `Staging build...`, status: "active", }) diff --git a/garden-service/src/tasks/push.ts b/garden-service/src/tasks/push.ts index a4f0c835c2..1aa1ad370d 100644 --- a/garden-service/src/tasks/push.ts +++ b/garden-service/src/tasks/push.ts @@ -105,7 +105,9 @@ export class PushTask extends BaseTask { throw err } - if (result.message) { + if (result.pushed) { + log.setSuccess({ msg: chalk.green(result.message || `Done (took ${log.getDuration(1)} sec)`), append: true }) + } else if (result.message) { log.setWarn({ msg: result.message, append: true }) } else { log.setSuccess({ msg: chalk.green(result.message || `Done (took ${log.getDuration(1)} sec)`), append: true }) diff --git a/garden-service/src/util/validate-dependencies.ts b/garden-service/src/util/validate-dependencies.ts index 6cf8ae1ca0..93e403e61e 100644 --- a/garden-service/src/util/validate-dependencies.ts +++ b/garden-service/src/util/validate-dependencies.ts @@ -88,7 +88,11 @@ export function detectMissingDependencies( const errMsg = "Unknown dependencies detected.\n\n" + indentString(missingDepDescriptions.join("\n\n"), 2) + "\n" - return new ConfigurationError(errMsg, { "unknown-dependencies": missingDepDescriptions }) + return new ConfigurationError(errMsg, { + unknownDependencies: missingDepDescriptions, + availableModules: Array.from(moduleNames), + availableServicesAndTasks: Array.from(runtimeNames), + }) } else { return null }