From 1136378b9d9fb4b002ac419ab744c07f8e15ef68 Mon Sep 17 00:00:00 2001
From: Vladimir Vagaytsev <vladimir.vagaitsev@gmail.com>
Date: Thu, 7 Sep 2023 10:54:51 +0200
Subject: [PATCH] refactor: move input args check into `getForwardablePorts`

---
 core/src/plugins/kubernetes/kubernetes-type/handlers.ts | 2 +-
 core/src/plugins/kubernetes/port-forward.ts             | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/core/src/plugins/kubernetes/kubernetes-type/handlers.ts b/core/src/plugins/kubernetes/kubernetes-type/handlers.ts
index 98a54387e0f..acb6ab4fec1 100644
--- a/core/src/plugins/kubernetes/kubernetes-type/handlers.ts
+++ b/core/src/plugins/kubernetes/kubernetes-type/handlers.ts
@@ -298,7 +298,7 @@ export const getKubernetesDeployStatus: DeployActionHandler<"getStatus", Kuberne
   }
 
   // Note: Local mode has its own port-forwarding configuration
-  if (deployedMode !== "local" && remoteResources && remoteResources.length > 0) {
+  if (deployedMode !== "local") {
     try {
       forwardablePorts = getForwardablePorts({ resources: remoteResources, parentAction: action, mode: deployedMode })
     } catch (error) {
diff --git a/core/src/plugins/kubernetes/port-forward.ts b/core/src/plugins/kubernetes/port-forward.ts
index 1821fab2fed..ed7bc7a7ab9 100644
--- a/core/src/plugins/kubernetes/port-forward.ts
+++ b/core/src/plugins/kubernetes/port-forward.ts
@@ -228,6 +228,10 @@ export function getForwardablePorts({
   parentAction: Resolved<KubernetesDeployAction | HelmDeployAction> | undefined
   mode: ActionMode
 }): ForwardablePort[] {
+  if (resources.length === 0) {
+    return []
+  }
+
   const spec = parentAction?.getSpec()
 
   // Note: Local mode has its own port-forwarding configuration