Skip to content

Commit

Permalink
fix(k8s): don't use --wait when installing using Helm
Browse files Browse the repository at this point in the history
This allows us to get more useful info when deployments fail, since
Helm just returns an unhelpful timeout error after a long wait.
  • Loading branch information
edvald committed Feb 22, 2019
1 parent 2b303d3 commit 02cd157
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions garden-service/src/plugins/kubernetes/helm/deployment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ export async function deployService(
"--name", releaseName,
"--namespace", namespace,
"--values", valuesPath,
"--wait",
]
if (force) {
installArgs.push("--replace")
Expand All @@ -70,7 +69,6 @@ export async function deployService(
"--install",
"--namespace", namespace,
"--values", valuesPath,
"--wait",
]
if (force) {
upgradeArgs.push("--force")
Expand Down

0 comments on commit 02cd157

Please sign in to comment.