Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeout period is longer than necessary #12

Open
philwmcdonald opened this issue Jul 1, 2021 · 0 comments
Open

timeout period is longer than necessary #12

philwmcdonald opened this issue Jul 1, 2021 · 0 comments

Comments

@philwmcdonald
Copy link

Calculated TBit is 1/10 the real value due to a missing zero. For 19200 baud TBit is 52ms not 5ms.
and 52 vs 50 isn't 40% different it's 4%. so the *14 to recover the missing resolution goes too far.

Probably shouldn't wait 2 frames for a response either.

A better timeout value would be:
timeout = (34+90)*1000000UL/serialSpd;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant