Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Casting Craziness #6

Open
ilanpillemer opened this issue Oct 4, 2016 · 0 comments
Open

Map Casting Craziness #6

ilanpillemer opened this issue Oct 4, 2016 · 0 comments

Comments

@ilanpillemer
Copy link
Contributor

ilanpillemer commented Oct 4, 2016

SignedRequestMap provides an interface to different forms of the Map to handle casting craziness between different environments. (eg Websockets and JAX-RS).

However the client still needs to somehow know what to choose requiring assumed experience with the craziness. This should be improved to use some kind of creational pattern (factory perhaps) so the client just gets the right kind of Map and doesn't need to even know that there is craziness.

Also this moves all the specific knowledge code into the signed library, and future changes would probably not have changes also in clients, and be localised to the library and thus transparent to clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant