This repository has been archived by the owner on Dec 7, 2020. It is now read-only.
Adding config option to skip tls verify for OpenID provider #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gambol99
suggested changes
Nov 7, 2016
| @@ -115,6 +115,8 @@ type Config struct { | |||
| RedirectionURL string `json:"redirection-url" yaml:"redirection-url"` | |||
| // RevocationEndpoint is the token revocation endpoint to revoke refresh tokens | |||
| RevocationEndpoint string `json:"revocation-url" yaml:"revocation-url"` | |||
| // skips the tls verification for openid provider communication | |||
There was a problem hiding this comment.
Needs the variable name added to the comment ...as it's exported (go-vet will complain) .. i.e.
// SkipOpenIDProviderTLSVerify skip ...
johanneslanger
force-pushed
the
feature/skip_openid_provider_tls_verify
branch
from
3b0f2e3 to
86fdd1d
Compare
|
Ok, updated the comment to include the variable name! |
|
thank you for the fix @johanneslanger :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to issue #146
Did this fix today so we are unblocked. Would love to get this in. Let me know what you think!
The config param defaults to false as this could be a security issue if set to true in production.
Did not find a quick way to write test for this though :(
Let me know what you think!