Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit link styles for some themes #3073

Open
andeng1106 opened this issue Feb 22, 2024 · 0 comments · May be fixed by #3378
Open

Inherit link styles for some themes #3073

andeng1106 opened this issue Feb 22, 2024 · 0 comments · May be fixed by #3378

Comments

@andeng1106
Copy link

andeng1106 commented Feb 22, 2024

Describe the bug

  • Issue related to: https://www.notion.so/Rui-Raposo-094d33377f4e40679edd14ddc91d79f0
  • Issue in both editor and frontend
  • This issue applies to blocks such as:
    • Icon List block
    • Table of Contents block
    • Button block
  • Issue applies to themes such as but not limited to:
    • 2024 theme (Editor > Styles)
    • Blocksy (Customize > General > Entry Content > Links Type or see docs)
      • Note: Choose "Link Type 4" to see the difference
    • Kadence (Customize > Colors & Fonts > Colors > Content Links > Link Style or see docs)
      • Note: Choose "Background on Hover" to see the difference

To Reproduce
Steps to reproduce the behavior:

  1. Add new page (or skip steps 2-7 and use this test page instead)
  2. Add an Icon List block
  3. Add a link to one of the Icon List item
  4. Add a TOC block
  5. Add Heading blocks to fill the TOC block
  6. Add a Button block
  7. Change button style to "Link"
  8. Switch to any of the themes above
  9. Change Link styles in the theme customizer/editor
  10. See that the three blocks mentioned above is not inheriting the styles properly

Expected behavior

  • Button block > link style, Icon List with link, and TOC block contents should inherit link styles for some themes
  • A sample of how it's inherited properly for Stackable's Text block:
Screen.Recording.2024-02-22.at.4.23.06.PM.mov

Screenshots
2024 theme
Note: Seems to be working properly in 2024 theme but double check just in case

2024.theme.link.styles.mov

Blocksy Theme

Screen.Recording.2024-02-22.at.4.27.21.PM.mov

Kadence Theme

Screen.Recording.2024-02-22.at.4.25.23.PM.mov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants