Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All GATK 1.4 tools should be marked as deprecated at org. Update: Removed #198

Closed
jennaj opened this issue Mar 4, 2019 · 9 comments
Closed
Labels
functionality usegalaxy.org tool/dependency/function fix usegalaxy.org functionality usegalaxy.* tool/dependency/function fix all usegalaxy.*

Comments

@jennaj
Copy link
Member

jennaj commented Mar 4, 2019

Looks like this got "undone" when the tool panel was updated to synch with the other usegalaxy.* servers.

screen shot 2019-03-04 at 8 50 58 am

@jennaj jennaj added the functionality usegalaxy.org tool/dependency/function fix usegalaxy.org label Mar 4, 2019
@hexylena
Copy link
Member

hexylena commented Mar 6, 2019

Looks like .eu doesn't include the same deprecations. I'll update us.

@jennaj broader question and probably not the place for it, but, at the risk of asking you to do extra work, would you want to expand the 'functionality on Main' to 'functionality on *', at least for a subset of issues like this one where we want to be consistent?

@martenson
Copy link
Member

We could keep and share a list of deprecated tools. Yaml anybody?

@hexylena
Copy link
Member

hexylena commented Mar 7, 2019

@martenson yeah, something in https://github.com/galaxyproject/usegalaxy-tools would be good. We can figure out the automation later.

@jennaj
Copy link
Member Author

jennaj commented Mar 12, 2019

@erasche I'll add in a new tag :)

@jennaj jennaj added the functionality usegalaxy.* tool/dependency/function fix all usegalaxy.* label Mar 12, 2019
@jennaj
Copy link
Member Author

jennaj commented Nov 14, 2019

Looks like this is still a problem. Or maybe got reverted in the last revision?

My goal is to learn what is new/valid and what is outdated and to make sure our users can understand that, too, in a clear way, before they waste time running tools that have known issues we won't ever address. How to do that -- I'm flexible!! Whatever works for everyone since we are synching up.

Maybe move the entire "GATK tools" group down into the "Deprecated" section, plus add the tag for individual tools? People still are using these, getting errors, and not understanding why. The GATK version behind most of these is 1.4, which is super old by now. The tools fail for all kinds of reasons: some are known wrapper bugs and some are usage issues. But since we aren't fixing the old wrappers, digging into what is going wrong is problematic. And even if the tool doesn't fail, can the result be "trusted"?

This is what ORG's tool panel looks like. All are v 1.4 from what I can tell.

Screen Shot 2019-11-13 at 4 31 56 PM

This is what EU's tool panel looks like. Mix of GATK4 (new, assume is "good"), then the others are a mix of the older v 2.x and v 1.4.

Screen Shot 2019-11-13 at 4 40 01 PM

@jennaj
Copy link
Member Author

jennaj commented Nov 14, 2019

Related ticket, was a suggestion to "hide" any that are deprecated by default. Not sure how others feel about that.

#241

@jennaj
Copy link
Member Author

jennaj commented Apr 23, 2020

End-users, please see: #281 (comment)

@jennaj
Copy link
Member Author

jennaj commented Sep 16, 2020

Reverted again. The only GATK not to mark as deprecated should be GATK4 Mutect2.

Users get confused when tool panel search and do not view the tool section -- each tool should be annotated.

Ideas about how to keep this from getting unset?

@jennaj jennaj reopened this Sep 16, 2020
@jennaj
Copy link
Member Author

jennaj commented Jan 7, 2021

All GATK 1.4 tools have been removed from the server as deprecated and non-functional.

Closing

@jennaj jennaj closed this as completed Jan 7, 2021
@jennaj jennaj changed the title All GATK tools should be marked as deprecated at org All GATK 1.4 tools should be marked as deprecated at org. Update: Removed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functionality usegalaxy.org tool/dependency/function fix usegalaxy.org functionality usegalaxy.* tool/dependency/function fix all usegalaxy.*
Projects
None yet
Development

No branches or pull requests

3 participants