-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update tutorials using HISAT2 to new version #552
Comments
I guess this is a good example why we should avoid including screenshots of tools. Any opinions about this? |
I just stumbled over the same issue. Removing the screenshots would not be sufficient, since also parameter names or the available parameters change. I would suggest to keep the screenshots, but to include the version of the used tools in the tolls.yml file (and maybe in the tutorial text?). |
The revision will be included as soon as we auto generate the tools.yml file from the workflow files. But I still think the parameter names are way more stable then images. |
It's easier for maintainability to remove the images but I think it's easier for users if there are images in the tutorials (I've had a user asking if the material could have more screenshots). I have no idea if this is possible but the ideal solution imho would be if the tutorials could be automatically run (Selenium-style?) to test that they work and auto-generate the screenshots. |
on the other hand there are the tours |
I have the feeling that if the parameters are clearly described (full name of the parameters, clear value, parameters in the same order as they appear in the Galaxy interface) the screenshot are not really needed (some time bad quality and more difficult to update): At least, we can also add comment about the parameters directly and it is easier to update and less issue also with the name of the input 😄 |
some parameter settings are described only in the screenshots, which is not good for accessibility either. There should always be a text description as well imho. Problem with screenshots is they need to be updated not only when the tool changes, but also when the UI changes, which makes it harder to track when a tutorial needs updating. Except for things like the 101 where we explicitly explain the UI I would be in favour of discouraging screenshots as well. If the textual descriptions are confusing to users we should think about how to improve/unify them. |
oh yes I totally forgot about the tours!! |
Yes! :) We should add it to the guidelines then, that we discourage to add many screenshots. Make it something like a soft-rule. What does @nekrut thinks about it? |
@mblue9 what about Star. Should we remove all figures and include Star as mapper? |
@bgruening I have never tried Star (the large memory requirement put me off) but I've heard it's good. Happy to use it if you and others think it'd be better here. |
Creating this issue to flag that, as HISAT2 has been updated, the current screenshots and text in some GTN tutorials no longer match the newest version of the tool, so will need to be updated at some stage e.g. these tuts
Happy to help update if you like when I get a chance.
The text was updated successfully, but these errors were encountered: