From 0894a62f0b65104771eb37c19e6421d45b03af8d Mon Sep 17 00:00:00 2001 From: Saskia Hiltemann Date: Fri, 2 Aug 2024 15:14:40 +0200 Subject: [PATCH 1/5] add column to indicate PR already openend --- bin/google-form-recordings.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/bin/google-form-recordings.rb b/bin/google-form-recordings.rb index 7ff528e1a3f33f..b54ae747c12cd8 100755 --- a/bin/google-form-recordings.rb +++ b/bin/google-form-recordings.rb @@ -20,6 +20,7 @@ col_length = 5 col_speakers = 6 col_galaxyversion = 10 +col_prmade = 12 ## recordings metadata definition on tutorials/slides # @@ -45,8 +46,8 @@ speakers = row[col_speakers] date = submission_date.strftime('%Y-%m-%d') - if row[col_material] == 'TESTING' - STDERR.puts "Skipping #{filename} as it is a test" + if row[col_material] == 'TESTING' or row[col_prmade] == 'yes' + STDERR.puts "Skipping recording as it is a test or a PR was already openened" next end From 9161c36bec276e33ba62ccf1674298a68d2c4263 Mon Sep 17 00:00:00 2001 From: Saskia Hiltemann Date: Fri, 2 Aug 2024 15:16:01 +0200 Subject: [PATCH 2/5] add marking of open PR to checklist --- .github/workflows/google-form-recordings.yml | 23 ++++++++++---------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/.github/workflows/google-form-recordings.yml b/.github/workflows/google-form-recordings.yml index 0f14de766e5d44..5c014a9cfd55ef 100644 --- a/.github/workflows/google-form-recordings.yml +++ b/.github/workflows/google-form-recordings.yml @@ -57,18 +57,19 @@ jobs: New recording submitted! **Submission Process checklist** - - [x] **Instructor** Record video - - [x] **Instructor** Submit video via form - - [x] **GTN** Pull request made by bot - - [ ] **GTN** Check if adjustments to PR are necessary + - [x] **Instructor:** Record video + - [x] **Instructor:** Submit video via form + - [x] **GTN:** Pull request made by bot + - [ ] **GTN:** Check if adjustments to PR are necessary - [ ] Check [Submissions Form](https://docs.google.com/spreadsheets/d/1iXjLlMEH5QMAMyUMHi1c_Lb7OiJhL_9hgJrtAsBoZ-Y/edit?usp=sharing) - [ ] New contributors need to be added? - - [ ] **GTN** Upload video to [GalaxyProject YouTube](https://www.youtube.com/c/galaxyproject) - - [ ] **GTN** Add youtube video id to PR after upload - - [ ] **GTN** Put Autogenerated captions in Google Doc ([folder](https://drive.google.com/drive/folders/1liyqDQDbxMNXvpQIaqFmoE2fB2aJIH9N?usp=drive_link)) - - [ ] **Instructor** Fix autogenerated captions, comment here when done - - [ ] **GTN** Upload fixed captions to YouTube - - [ ] **GTN** Add the people who did the captioning to this PR - - [ ] **GTN** Merge PR! + - [ ] Mark the 'PR made?' column as 'yes' + - [ ] **GTN:** Upload video to [GalaxyProject YouTube](https://www.youtube.com/c/galaxyproject) + - [ ] **GTN:** Add youtube video id to PR after upload + - [ ] **GTN:** Put Autogenerated captions in Google Doc ([folder](https://drive.google.com/drive/folders/1liyqDQDbxMNXvpQIaqFmoE2fB2aJIH9N?usp=drive_link)) + - [ ] **Instructor:** Fix autogenerated captions, comment here when done + - [ ] **GTN:** Upload fixed captions to YouTube + - [ ] **GTN:** Add the people who did the captioning to this PR + - [ ] **GTN:** Merge PR! From 7c3093bb580b417a273b26428899882ba3402d88 Mon Sep 17 00:00:00 2001 From: Saskia Hiltemann Date: Fri, 2 Aug 2024 15:16:46 +0200 Subject: [PATCH 3/5] wording --- .github/workflows/google-form-recordings.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/google-form-recordings.yml b/.github/workflows/google-form-recordings.yml index 5c014a9cfd55ef..82989acd995097 100644 --- a/.github/workflows/google-form-recordings.yml +++ b/.github/workflows/google-form-recordings.yml @@ -63,7 +63,7 @@ jobs: - [ ] **GTN:** Check if adjustments to PR are necessary - [ ] Check [Submissions Form](https://docs.google.com/spreadsheets/d/1iXjLlMEH5QMAMyUMHi1c_Lb7OiJhL_9hgJrtAsBoZ-Y/edit?usp=sharing) - [ ] New contributors need to be added? - - [ ] Mark the 'PR made?' column as 'yes' + - [ ] Mark the 'PR made?' column as 'yes' in the spreadsheet - [ ] **GTN:** Upload video to [GalaxyProject YouTube](https://www.youtube.com/c/galaxyproject) - [ ] **GTN:** Add youtube video id to PR after upload - [ ] **GTN:** Put Autogenerated captions in Google Doc ([folder](https://drive.google.com/drive/folders/1liyqDQDbxMNXvpQIaqFmoE2fB2aJIH9N?usp=drive_link)) From 34ceef973b58da7c20c1878b69c2e5518b5f37c0 Mon Sep 17 00:00:00 2001 From: Saskia Hiltemann Date: Fri, 2 Aug 2024 15:30:50 +0200 Subject: [PATCH 4/5] tweak checklist --- .github/workflows/google-form-recordings.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/google-form-recordings.yml b/.github/workflows/google-form-recordings.yml index 82989acd995097..7a8c85bd7d4afd 100644 --- a/.github/workflows/google-form-recordings.yml +++ b/.github/workflows/google-form-recordings.yml @@ -60,12 +60,11 @@ jobs: - [x] **Instructor:** Record video - [x] **Instructor:** Submit video via form - [x] **GTN:** Pull request made by bot - - [ ] **GTN:** Check if adjustments to PR are necessary - - [ ] Check [Submissions Form](https://docs.google.com/spreadsheets/d/1iXjLlMEH5QMAMyUMHi1c_Lb7OiJhL_9hgJrtAsBoZ-Y/edit?usp=sharing) - - [ ] New contributors need to be added? + - [ ] **GTN:** Check [Submissions Spreadsheet](https://docs.google.com/spreadsheets/d/1iXjLlMEH5QMAMyUMHi1c_Lb7OiJhL_9hgJrtAsBoZ-Y/edit?usp=sharing) - [ ] Mark the 'PR made?' column as 'yes' in the spreadsheet + - [ ] Add any new contributors to `CONTRIBUTORS.yaml` file - [ ] **GTN:** Upload video to [GalaxyProject YouTube](https://www.youtube.com/c/galaxyproject) - - [ ] **GTN:** Add youtube video id to PR after upload + - [ ] **GTN:** Add YouTube video id to PR after upload - [ ] **GTN:** Put Autogenerated captions in Google Doc ([folder](https://drive.google.com/drive/folders/1liyqDQDbxMNXvpQIaqFmoE2fB2aJIH9N?usp=drive_link)) - [ ] **Instructor:** Fix autogenerated captions, comment here when done - [ ] **GTN:** Upload fixed captions to YouTube From afb34910a719d38ab764677c0dba0be5e3e87222 Mon Sep 17 00:00:00 2001 From: Saskia Hiltemann Date: Fri, 2 Aug 2024 15:32:33 +0200 Subject: [PATCH 5/5] tweak checklist --- .github/workflows/google-form-recordings.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/google-form-recordings.yml b/.github/workflows/google-form-recordings.yml index 7a8c85bd7d4afd..6179afee051742 100644 --- a/.github/workflows/google-form-recordings.yml +++ b/.github/workflows/google-form-recordings.yml @@ -62,6 +62,7 @@ jobs: - [x] **GTN:** Pull request made by bot - [ ] **GTN:** Check [Submissions Spreadsheet](https://docs.google.com/spreadsheets/d/1iXjLlMEH5QMAMyUMHi1c_Lb7OiJhL_9hgJrtAsBoZ-Y/edit?usp=sharing) - [ ] Mark the 'PR made?' column as 'yes' in the spreadsheet + - [ ] Ping speakers on this PR - [ ] Add any new contributors to `CONTRIBUTORS.yaml` file - [ ] **GTN:** Upload video to [GalaxyProject YouTube](https://www.youtube.com/c/galaxyproject) - [ ] **GTN:** Add YouTube video id to PR after upload