Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure for tool: Assertion for h5 fails claiming that h5py is not installed (but it is if you go to the venv for galaxy) #1333

Closed
pcm32 opened this issue Nov 29, 2022 · 4 comments

Comments

@pcm32
Copy link
Member

pcm32 commented Nov 29, 2022

Hi there!

After installing the latest planemo version on a venv, and then running on this tool:

planemo test anndata_operations.xml

We get errors in the tests with h5 assertion requires unavailable optional dependency h5py.

However, descending into the galaxy venv created by planemo, shows that the package is indeed installed (and h5py is in the list of required dependencies for galaxy), redoing the same steps Galaxy seems to be doing:

(gx_venv_3) [pcm32@tololo scanpy]$ python
Python 3.9.5 (default, Jul 27 2021, 12:28:44) 
[GCC 10.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import io
>>> 
>>> try:
...       import h5py
... except ImportError:
...       h5py = None
... 
>>> h5py
<module 'h5py' from '/main/homes/pcm32/.planemo/gx_venv_3/lib/python3.9/site-packages/h5py/__init__.py'>
>>> def _assert_h5py():
...     if h5py is None:
...         raise Exception(IMPORT_MISSING_MESSAGE)
... 
>>> _assert_h5py()
# no exception raised...

I also see this with an older version of Galaxy (21.01 I think) being used in a CI (see artifacts here at the bottom if it helps).

I'm not sure if this is more of a Galaxy bug rather than planemo, but since it happened in both occasions from planemo I thought I should raise it here. Thanks!

@mvdbeek
Copy link
Member

mvdbeek commented Nov 29, 2022

Fixed in #1326, I'll cut a release tomorrow

@pcm32
Copy link
Member Author

pcm32 commented Nov 29, 2022

Great! Thanks, will try it as I see it.

@mvdbeek
Copy link
Member

mvdbeek commented Nov 30, 2022

Release is up, https://pypi.org/project/planemo/0.75.3/. Let me know if this doesn't fix it.

@mvdbeek mvdbeek closed this as completed Nov 30, 2022
@pcm32
Copy link
Member Author

pcm32 commented Dec 1, 2022

I can confirm it is working now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants