Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload > Rule-based tab -- "Reset" button is greyed out any prior data/settings remain #13405

Closed
jennaj opened this issue Feb 18, 2022 · 1 comment

Comments

@jennaj
Copy link
Member

jennaj commented Feb 18, 2022

Describe the bug
Upload > Rule-based > "Reset" button remains greyed out after a prior load/submission after opening the Upload tool again. No way to clear prior with a single click. The "Reset" button on the "Regular" tab doesn't clear the "Rule-based" tab. Can reproduce at ORG(22.01 pre-release) + EU(21.09) + GCP(22.01 pre-release) -- must have been none functional at least since 21.09.

Galaxy Version and/or server at which you observed the bug
Galaxy Version: (check <galaxy_url>/api/version if you don't know)
Commit: (run git rev-parse HEAD if you run this Galaxy server)

To Reproduce
Steps to reproduce the behavior:

  1. Go to Upload tool > Rule-based tab
  2. Paste something in there and load it
  3. Go back to the Upload > Rule-based tab
  4. Any prior data/settings remain, "Reset" button is greyed out
  5. (The pop-up over all three buttons is the same, long, and reports a non-specific odd message -- see screenshot, and @astrovsky01 noticed it can cover the buttons)
  6. To clear that, must manually remove or change prior data/settings
  7. Going forward to the "Build" form, "Reset" only clears the rules applied, not the data (this was expected)

Expected behavior

  1. Make the "Reset" button active under Upload > Rule-based tab
  2. Make the "Reset" button under Upload > Regular (first tab) clear all non-default settings present in any Upload tab

Screenshots
Screen Shot 2022-02-17 at 3 16 36 PM

Screen Shot 2022-02-17 at 3 31 01 PM

Screen Shot 2022-02-17 at 3 29 30 PM

Additional context
Found during 22.01 release testing with this GTN tutorial

@assuntad23
Copy link
Contributor

Fixed with #13443

@jennaj jennaj added this to the 22.01 milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants