From 4e770c5178496f68987bdc22ca6fe87c6cece652 Mon Sep 17 00:00:00 2001
From: Martin Cech <marten@bx.psu.edu>
Date: Fri, 28 Apr 2023 11:32:04 -0700
Subject: [PATCH] minor tooltip and UI client changes

---
 client/src/components/Common/DelayedInput.vue       |  8 ++++++--
 .../components/DatasetInformation/DatasetSource.vue |  3 ++-
 .../History/Content/Dataset/DatasetActions.vue      |  2 +-
 .../HistoryFilters/HistoryFilters.vue               |  6 ++++++
 client/src/components/Indices/IndexFilter.vue       | 13 +++++++++++--
 .../Markdown/Elements/Workflow/WorkflowDisplay.vue  |  5 +++--
 client/src/components/Panels/ToolBoxWorkflow.vue    |  2 ++
 client/src/components/plugins/icons.js              |  2 ++
 8 files changed, 33 insertions(+), 8 deletions(-)

diff --git a/client/src/components/Common/DelayedInput.vue b/client/src/components/Common/DelayedInput.vue
index 0c771ec06c8a..3f31fa314599 100644
--- a/client/src/components/Common/DelayedInput.vue
+++ b/client/src/components/Common/DelayedInput.vue
@@ -13,6 +13,8 @@
         <b-input-group-append>
             <b-button
                 v-if="enableAdvanced"
+                v-b-tooltip.hover
+                aria-haspopup="true"
                 size="sm"
                 :pressed="showAdvanced"
                 :variant="showAdvanced ? 'info' : 'secondary'"
@@ -23,6 +25,8 @@
                 <icon v-else icon="angle-double-down" />
             </b-button>
             <b-button
+                v-b-tooltip.hover
+                aria-haspopup="true"
                 class="search-clear"
                 size="sm"
                 :title="titleClear | l"
@@ -67,8 +71,8 @@ export default {
             queryInput: null,
             queryTimer: null,
             queryCurrent: null,
-            titleClear: "clear search (esc)",
-            titleAdvanced: "toggle advanced search",
+            titleClear: "Clear Search (esc)",
+            titleAdvanced: "Toggle Advanced Search",
         };
     },
     watch: {
diff --git a/client/src/components/DatasetInformation/DatasetSource.vue b/client/src/components/DatasetInformation/DatasetSource.vue
index 009614ef94e0..13fa5018a3f8 100644
--- a/client/src/components/DatasetInformation/DatasetSource.vue
+++ b/client/src/components/DatasetInformation/DatasetSource.vue
@@ -21,6 +21,7 @@ import { library } from "@fortawesome/fontawesome-svg-core";
 import { faCopy, faExternalLinkAlt } from "@fortawesome/free-solid-svg-icons";
 import { copy } from "utils/clipboard";
 import DatasetSourceTransform from "./DatasetSourceTransform";
+import _l from "utils/localization";
 
 library.add(faCopy, faExternalLinkAlt);
 
@@ -46,7 +47,7 @@ export default {
     },
     methods: {
         copyLink() {
-            copy(this.sourceUri, "Link copied to the clipboard.");
+            copy(this.sourceUri, _l("Link copied to your clipboard"));
         },
     },
 };
diff --git a/client/src/components/History/Content/Dataset/DatasetActions.vue b/client/src/components/History/Content/Dataset/DatasetActions.vue
index 70191848b2ff..fd67a64ef081 100644
--- a/client/src/components/History/Content/Dataset/DatasetActions.vue
+++ b/client/src/components/History/Content/Dataset/DatasetActions.vue
@@ -123,7 +123,7 @@ export default {
     },
     methods: {
         onCopyLink() {
-            const msg = this.localize("Link is copied to your clipboard");
+            const msg = this.localize("Link copied to your clipboard");
             sendToClipboard(absPath(this.downloadUrl), msg);
         },
         onDownload(resource) {
diff --git a/client/src/components/History/CurrentHistory/HistoryFilters/HistoryFilters.vue b/client/src/components/History/CurrentHistory/HistoryFilters/HistoryFilters.vue
index d8d2fa46f80c..b1e0dd79cf55 100644
--- a/client/src/components/History/CurrentHistory/HistoryFilters/HistoryFilters.vue
+++ b/client/src/components/History/CurrentHistory/HistoryFilters/HistoryFilters.vue
@@ -13,17 +13,23 @@
             </DebouncedInput>
             <b-input-group-append>
                 <b-button
+                    v-b-tooltip.hover
+                    aria-haspopup="true"
                     size="sm"
                     :pressed="showAdvanced"
                     :variant="showAdvanced ? 'info' : 'secondary'"
                     data-description="show advanced filter toggle"
+                    title="Show Advanced Filter"
                     aria-label="Show advanced filter"
                     @click="onToggle">
                     <icon v-if="showAdvanced" icon="angle-double-up" />
                     <icon v-else icon="angle-double-down" />
                 </b-button>
                 <b-button
+                    v-b-tooltip.hover
+                    aria-haspopup="true"
                     size="sm"
+                    title="Clear Filters (esc)"
                     aria-label="Clear filters"
                     data-description="clear filters"
                     @click="updateFilter('')">
diff --git a/client/src/components/Indices/IndexFilter.vue b/client/src/components/Indices/IndexFilter.vue
index 0d7d9d86e1fb..f7eb2f8d6030 100644
--- a/client/src/components/Indices/IndexFilter.vue
+++ b/client/src/components/Indices/IndexFilter.vue
@@ -9,19 +9,28 @@
                     autocomplete="off"
                     :placeholder="placeholder | localize"
                     data-description="filter index input"
-                    class="search-query"
+                    class="search-query index-filter-query"
                     :size="size"
                     @input="input"
                     @keyup.esc="onReset" />
             </DebouncedInput>
             <b-input-group-append>
                 <b-button
-                    data-description="show deleted filter toggle"
+                    v-b-tooltip.hover
+                    aria-haspopup="true"
                     title="Advanced Filtering Help"
                     :size="size"
                     @click="onHelp">
                     <icon icon="question" />
                 </b-button>
+                <b-button
+                    v-b-tooltip.hover
+                    aria-haspopup="true"
+                    title="Clear Filters (esc)"
+                    :size="size"
+                    @click="onReset">
+                    <icon icon="times" />
+                </b-button>
             </b-input-group-append>
         </b-input-group>
         <b-modal v-model="showHelp" title="Filtering Options Help" ok-only>
diff --git a/client/src/components/Markdown/Elements/Workflow/WorkflowDisplay.vue b/client/src/components/Markdown/Elements/Workflow/WorkflowDisplay.vue
index d7a76d8b82cf..bbeb80e894b0 100644
--- a/client/src/components/Markdown/Elements/Workflow/WorkflowDisplay.vue
+++ b/client/src/components/Markdown/Elements/Workflow/WorkflowDisplay.vue
@@ -4,6 +4,7 @@ import { computed, ref, onMounted } from "vue";
 import { withPrefix } from "@/utils/redirect";
 import LoadingSpan from "@/components/LoadingSpan.vue";
 import WorkflowTree from "./WorkflowTree.vue";
+import { isEmpty } from "@/utils/utils";
 
 interface WorkflowDisplayProps {
     workflowId: string;
@@ -69,7 +70,7 @@ onMounted(async () => {
                     type="button"
                     class="py-0 px-1"
                     data-description="workflow import">
-                    <span class="fa fa-file-import" />
+                    <span class="fa fa-upload" />
                 </b-button>
             </span>
             <span>
@@ -80,7 +81,7 @@ onMounted(async () => {
         <b-card-body>
             <LoadingSpan v-if="loading" message="Loading Workflow" />
             <div v-else :class="!expanded && 'content-height'">
-                <b-alert v-if="errorContent !== null" variant="danger" show>
+                <b-alert v-if="!isEmpty(errorContent)" variant="danger" show>
                     <b>Please fix the following error(s):</b>
                     <ul v-if="typeof errorContent === 'object'" class="my-2">
                         <li v-for="(errorValue, errorKey) in errorContent" :key="errorKey">
diff --git a/client/src/components/Panels/ToolBoxWorkflow.vue b/client/src/components/Panels/ToolBoxWorkflow.vue
index 251ad3c8497b..74dd9d4652d7 100644
--- a/client/src/components/Panels/ToolBoxWorkflow.vue
+++ b/client/src/components/Panels/ToolBoxWorkflow.vue
@@ -16,6 +16,8 @@
         </div>
         <div class="unified-panel-controls">
             <tool-search
+                v-b-tooltip.hover
+                aria-haspopup="true"
                 :current-panel-view="currentPanelView"
                 placeholder="search tools"
                 :toolbox="workflowTools"
diff --git a/client/src/components/plugins/icons.js b/client/src/components/plugins/icons.js
index ab5524e414e1..afba8041f04b 100644
--- a/client/src/components/plugins/icons.js
+++ b/client/src/components/plugins/icons.js
@@ -17,6 +17,7 @@ import {
     faEllipsisH,
     faEllipsisV,
     faExchangeAlt,
+    faExternalLinkAlt,
     faEye,
     faFileArchive,
     faFileExport,
@@ -62,6 +63,7 @@ library.add(
     faEllipsisH,
     faEllipsisV,
     faExchangeAlt,
+    faExternalLinkAlt,
     faEye,
     faFileArchive,
     faFileExport,