From 5fb9146df9fba708656f78ca9e8e85a1420928a2 Mon Sep 17 00:00:00 2001
From: Pau Andrio <andriopau@gmail.com>
Date: Mon, 22 Jul 2024 19:46:36 +0200
Subject: [PATCH] Using from_work_dir attribute to avoid touch and ln on
 outputs

---
 tools/biobb_pytorch/biobb_apply_mdae.xml | 21 ++++----------------
 tools/biobb_pytorch/biobb_train_mdae.xml | 25 ++++--------------------
 2 files changed, 8 insertions(+), 38 deletions(-)

diff --git a/tools/biobb_pytorch/biobb_apply_mdae.xml b/tools/biobb_pytorch/biobb_apply_mdae.xml
index 259ab8a1..e6fa65de 100644
--- a/tools/biobb_pytorch/biobb_apply_mdae.xml
+++ b/tools/biobb_pytorch/biobb_apply_mdae.xml
@@ -10,26 +10,13 @@
 
     <command detect_errors="exit_code"><![CDATA[
 
-      `#Required inputs using file extension`
       ln -s '$input_data_npy_path' ./input_data_npy_path.$input_data_npy_path.ext &&
       ln -s '$input_model_pth_path' ./input_model_pth_path.pth &&
 
-      `#Optional inputs using file extension`
       #if $config_json:
         ln -s '$config_json' ./config_json.$config_json.ext &&
       #end if
 
-      `#Required Outputs using file extension`
-      touch '$output_reconstructed_data_npy_path' &&
-      ln -s '$output_reconstructed_data_npy_path' ./output_reconstructed_data_npy_path.$output_reconstructed_data_npy_path.ext &&
-
-      `#Optional Outputs using file extension`
-      #if $output_latent_space_npy_path:
-        touch '$output_latent_space_npy_path' &&
-        ln -s '$output_latent_space_npy_path' ./output_latent_space_npy_path.$output_latent_space_npy_path.ext &&
-      #end if
-
-      `#Command`
       apply_mdae
 
       #if $config_json:
@@ -39,9 +26,9 @@
       --input_data_npy_path ./input_data_npy_path.$input_data_npy_path.ext
       --input_model_pth_path ./input_model_pth_path.pth
       #if $output_latent_space_npy_path:
-      --output_latent_space_npy_path ./output_latent_space_npy_path.$output_latent_space_npy_path.ext
+      --output_latent_space_npy_path ./output_latent_space_npy_path.npy
       #end if
-      --output_reconstructed_data_npy_path ./output_reconstructed_data_npy_path.$output_reconstructed_data_npy_path.ext
+      --output_reconstructed_data_npy_path ./output_reconstructed_data_npy_path.npy
       ;
       ]]>
     </command>
@@ -53,8 +40,8 @@
     </inputs>
 
     <outputs>
-      <data format="npy" name="output_reconstructed_data_npy_path" label="output_reconstructed_data_npy_path" />
-      <data format="npy" name="output_latent_space_npy_path" label="output_latent_space_npy_path" />
+      <data format="npy" name="output_reconstructed_data_npy_path" from_work_dir="output_reconstructed_data_npy_path.npy" label="output_reconstructed_data_npy_path" />
+      <data format="npy" name="output_latent_space_npy_path" from_work_dir="output_latent_space_npy_path.npy" label="output_latent_space_npy_path" />
     </outputs>
 
     <tests>
diff --git a/tools/biobb_pytorch/biobb_train_mdae.xml b/tools/biobb_pytorch/biobb_train_mdae.xml
index 8fcb5959..44658d34 100644
--- a/tools/biobb_pytorch/biobb_train_mdae.xml
+++ b/tools/biobb_pytorch/biobb_train_mdae.xml
@@ -10,10 +10,8 @@
 
     <command detect_errors="exit_code"><![CDATA[
 
-      `#Required inputs using file extension`
       ln -s '$input_train_npy_path' ./input_train_npy_path.$input_train_npy_path.ext &&
 
-      `#Optional inputs using file extension`
       #if $input_model_pth_path:
         ln -s '$input_model_pth_path' ./input_model_pth_path.$input_model_pth_path.ext &&
       #end if
@@ -21,21 +19,6 @@
         ln -s '$config_json' ./config_json.$config_json.ext &&
       #end if
 
-      `#Required Outputs using file extension`
-      touch '$output_model_pth_path' &&
-      ln -s '$output_model_pth_path' ./output_model_pth_path.pth &&
-
-      `#Optional Outputs using file extension`
-      #if $output_train_data_npz_path:
-        touch '$output_train_data_npz_path' &&
-        ln -s '$output_train_data_npz_path' ./output_train_data_npz_path.npz &&
-      #end if
-      #if $output_performance_npz_path:
-        touch '$output_performance_npz_path' &&
-        ln -s '$output_performance_npz_path' ./output_performance_npz_path.npz &&
-      #end if
-
-      `#Command`
       train_mdae
 
       #if $config_json:
@@ -46,7 +29,7 @@
       #if $input_model_pth_path:
         --input_model_pth_path ./input_model_pth_path.$input_model_pth_path.ext
       #end if
-      --output_model_pth_path $output_model_pth_path
+      --output_model_pth_path ./output_model_pth_path.pth
       #if $output_train_data_npz_path:
         --output_train_data_npz_path ./output_train_data_npz_path.npz
       #end if
@@ -64,9 +47,9 @@
     </inputs>
 
     <outputs>
-      <data format="pth" name="output_model_pth_path" label="output_model_pth_path" />
-      <data format="npz" name="output_train_data_npz_path" label="output_train_data_npz_path" />
-      <data format="npz" name="output_performance_npz_path" label="output_performance_npz_path" />
+      <data format="pth" name="output_model_pth_path" from_work_dir="output_model_pth_path.pth" label="output_model_pth_path" />
+      <data format="npz" name="output_train_data_npz_path" from_work_dir="output_train_data_npz_path.npz" label="output_train_data_npz_path" />
+      <data format="npz" name="output_performance_npz_path" from_work_dir="output_performance_npz_path.npz" label="output_performance_npz_path" />
     </outputs>
 
     <tests>