Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't handle ED during router execution #820

Closed
mrq1911 opened this issue May 17, 2024 · 0 comments
Closed

Don't handle ED during router execution #820

mrq1911 opened this issue May 17, 2024 · 0 comments
Assignees

Comments

@mrq1911
Copy link
Member

mrq1911 commented May 17, 2024

If your trade route goes through insufficient assets that you don't hold already, you're charged 1.1 HDX to create an account, and then immediately when an asset is sold, you get 1 HDX refunded, making the swap 0.1 HDX more expensive technically.

Also, more rarely, if your trade amount is very small (or the ED of the asset is large), the execution can fail on the ED check of sufficient assets.

ED checks and fees should be ignored during the middle of router execution how to prevent this behavior. ED should still be handled correctly for the assets in and out of the route execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants