Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE_ASSET_ID bug in integration tests #818

Closed
green-jay opened this issue May 16, 2024 · 1 comment
Closed

CORE_ASSET_ID bug in integration tests #818

green-jay opened this issue May 16, 2024 · 1 comment
Assignees

Comments

@green-jay
Copy link
Contributor

Via Chris from Zeitgeist:
I found another strange thing in these XCM integration tests. You defined your CORE_ASSET_ID to be 0. Then you use your craft_exchange_asset_xcm function to swap HDX for HDX, because GeneralIndex is both zero. This makes no sense at the first glance. I expected to see an exchange swap of two different assets.

https://github.com/galacticcouncil/HydraDX-node/blob/e3821e078bdb72a0416f8aebca21ba4a7a599f64/integration-tests/src/exchange_asset.rs#L61

@dmoka
Copy link
Contributor

dmoka commented May 27, 2024

It is not a bug, as we do reanchoring of those assets when we construct the XCM message. But it is indeed implicit, will refactor it to make the assets more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants