New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for router.set_route() for different tradability states #791

Closed

jak-pan opened this issue Mar 19, 2024 · 0 comments · Fixed by #792

Assignees

Contributor

jak-pan commented Mar 19, 2024 •

edited

Loading

We don't have test where router.set_route() fails due to change in tradability flags of omnipool assets.

https://github.com/galacticcouncil/HydraDX-node/blob/a0c524a6c3d7613635614588901a51546782b341/pallets/omnipool/src/types.rs#L31-L35

Scenario:
DOT has BUY disabled
sell DOT->HDX will pass but HDX->DOT will fail due to BUY of DOT being disabled.

This is currently case with LRNA

jak-pan assigned dmoka

dmoka linked a pull request

that will close this issue

fix: add missing set route tests #792

Merged

3 tasks

dmoka closed this as completed in #792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment