This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(solc): add timeout and error detection for releases lookup #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
force-pushed
the
matt/soften-checksums
branch
from
16d9ec3 to
1770f1d
Compare
|
god bless savior PR |
gakonst
added a commit
to foundry-rs/foundry
that referenced
this pull request
Jan 5, 2022
introduces auto detection of hh vs dapptools style directories: gakonst/ethers-rs#761 fixes releases lookup timeout and checksum checking: gakonst/ethers-rs#759
charisma98
added a commit
to charisma98/foundry
that referenced
this pull request
Mar 4, 2023
introduces auto detection of hh vs dapptools style directories: gakonst/ethers-rs#761 fixes releases lookup timeout and checksum checking: gakonst/ethers-rs#759
0129general
added a commit
to 0129general/FoundryProject
that referenced
this pull request
May 8, 2024
introduces auto detection of hh vs dapptools style directories: gakonst/ethers-rs#761 fixes releases lookup timeout and checksum checking: gakonst/ethers-rs#759
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It seems like
https://binaries.soliditylang.orgis down, soReleasesrequests fail after some time with a DNS lookup error. which highlighted an issue:a) takes quite a bit of time
b) all checksums fail bc no checksums to compare against
Ref #751
Solution
PR Checklist