Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lodash's _.values() to drop the dependency on object.values #78

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Use lodash's _.values() to drop the dependency on object.values #78

merged 1 commit into from
Sep 4, 2018

Conversation

realityking
Copy link
Contributor

Always nice to have less dependencies and object.values pulls in a lot of them (it has 4 dependencies).

@coveralls
Copy link

coveralls commented Sep 4, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 130

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.756%
Totals Coverage Status
Change from base Build 128: 0.0%
Covered Lines: 161
Relevant Lines: 223
💛 - Coveralls

@gajus gajus merged commit 83b3b84 into gajus:master Sep 4, 2018
@gajus
Copy link
Owner

gajus commented Sep 4, 2018

🎉 This PR is included in version 5.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@realityking realityking deleted the lodash branch September 4, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realityking @coveralls @gajus