Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Leave default output unchanged when no output is provided #79

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented Oct 2, 2020

Description

when using the default OUTPUT we were joining the path, to the current directory joining the wrong path.

I've changed this to leave the default output unchanged

also pushing 1.2.4 and 1.2.5

@gagoar gagoar changed the title [BUG] Leave default output untouched when no output is provided [BUG] Leave default output unchanged when no output is provided Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #79 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          202       202           
  Branches        31        31           
=========================================
  Hits           202       202           
Flag Coverage Δ
#unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/commands/generate.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df7bbbf...d2da8d5. Read the comment docs.

@gagoar gagoar merged commit 79f8119 into master Oct 2, 2020
@gagoar gagoar deleted the gg/leave-output-untouched branch October 2, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant