Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing default from cli in favor of generate default instead. #78

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented Oct 2, 2020

the CLI provided a default value already and this overrides the custom configuration if provided.

relying on the default value provided in the generate instead.

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          202       202           
  Branches        31        31           
=========================================
  Hits           202       202           
Flag Coverage Δ
#unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25e2078...9beaf5e. Read the comment docs.

@gagoar gagoar merged commit df7bbbf into master Oct 2, 2020
@gagoar gagoar deleted the gg/removing-default-from-cli branch October 2, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant