Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier in CI #382

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Run prettier in CI #382

merged 2 commits into from
Nov 14, 2023

Conversation

gustavkj
Copy link
Collaborator

Run Prettier as part of the CI-pipeline.

Also, remove an ESLint rule which is already covered by Prettier (and otherwise turned off by eslint-config-prettier).

@coveralls
Copy link
Collaborator

coveralls commented Nov 11, 2023

Pull Request Test Coverage Report for Build 6835598123

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6833753525: 0.0%
Covered Lines: 261
Relevant Lines: 261

💛 - Coveralls

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e0328c2) 100.00% compared to head (1ef9ac9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #382   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          282       282           
  Branches        64        64           
=========================================
  Hits           282       282           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gustavkj gustavkj requested a review from gagoar November 11, 2023 17:21
@gustavkj gustavkj marked this pull request as ready for review November 11, 2023 17:21
Copy link
Owner

@gagoar gagoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gagoar gagoar merged commit 9955efc into gagoar:master Nov 14, 2023
@gustavkj gustavkj deleted the check-prettier branch November 14, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants