Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making --use-root-maintainers available via CLI #345

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented Mar 19, 2023

It was reported that --use-root-maintainers is not explicitly available via the CLI.

This PR should solved that, and close #344

@gagoar gagoar marked this pull request as ready for review March 19, 2023 02:12
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4458422274

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 4368655577: 0.0%
Covered Lines: 245
Relevant Lines: 245

💛 - Coveralls

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ad51db5) 100.00% compared to head (9198ed5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #345   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          262       262           
  Branches        57        57           
=========================================
  Hits           262       262           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gagoar gagoar requested a review from gustavkj March 19, 2023 02:13
@gagoar gagoar added the bug Something isn't working label Mar 19, 2023
@gagoar gagoar merged commit 4274334 into master Mar 19, 2023
@gagoar gagoar deleted the gg/making-use-root-maintainers-available-on-cli branch March 19, 2023 02:17
@gagoar gagoar mentioned this pull request Mar 19, 2023
gagoar added a commit that referenced this pull request Mar 19, 2023
this patch brings:
- Making `--use-root-maintainers` available via CLI
[`#345`](#345)
- dependency updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] --use-root-maintainers flag not available in latest release
2 participants