Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing mocked function from ts-jest #312

Merged
merged 4 commits into from
Jun 11, 2022

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented Jun 11, 2022

no need to see this when running tests!
image

I had some issues with sonarCloud so I took it out. The issues were around ignoring tests for duplication and then re-running the check. I believe some duplication in tests is necessary to understand use-cases. IMO It is documentation. Verbosity is desired in some cases.

@gagoar gagoar requested a review from gustavkj June 11, 2022 01:41
@coveralls
Copy link
Collaborator

coveralls commented Jun 11, 2022

Pull Request Test Coverage Report for Build 2480554512

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2470350865: 0.0%
Covered Lines: 230
Relevant Lines: 230

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #312 (727b4e8) into master (5266499) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #312   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          246       246           
  Branches        52        52           
=========================================
  Hits           246       246           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5266499...727b4e8. Read the comment docs.

Copy link
Collaborator

@gustavkj gustavkj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but using jest.mocked would not require adding the types yourself.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 11, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.7% 9.7% Duplication

@gagoar gagoar merged commit ba2f388 into master Jun 11, 2022
@gagoar gagoar deleted the gg/mocked-from-ts-jest-no-needed branch June 11, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants