-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing mocked function from ts-jest
#312
Conversation
Pull Request Test Coverage Report for Build 2480554512
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 246 246
Branches 52 52
=========================================
Hits 246 246
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but using jest.mocked
would not require adding the types yourself.
SonarCloud Quality Gate failed.
|
no need to see this when running tests!

I had some issues with sonarCloud so I took it out. The issues were around ignoring tests for duplication and then re-running the check. I believe some duplication in tests is necessary to understand use-cases. IMO It is documentation. Verbosity is desired in some cases.