Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing workflows to take node upgrades into account #296

Merged
merged 5 commits into from
May 6, 2022
Merged

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented May 6, 2022

In order to avoid issues with node, I've added a reusable workflow to take node version automagically.

I've also divided up workflows just for visibility sake.

@gagoar gagoar requested a review from gustavkj May 6, 2022 09:49
@coveralls
Copy link
Collaborator

coveralls commented May 6, 2022

Pull Request Test Coverage Report for Build 2281085479

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2280975277: 0.0%
Covered Lines: 230
Relevant Lines: 230

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #296 (53c87c0) into master (25d0678) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #296   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          246       246           
  Branches        52        52           
=========================================
  Hits           246       246           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d0678...53c87c0. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gagoar gagoar merged commit c576d10 into master May 6, 2022
@gagoar gagoar deleted the gg/workflows branch May 6, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants