moving to esbuild #185
Merged
moving to esbuild #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 508429290
💛 - Coveralls |
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 227 227
Branches 40 40
=========================================
Hits 227 227
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@vercel/nccis quite unmaintained. and IMO losing relevance. Particularly because it uses Webpack in a really narrow way (what makes a really simple plug and play tool), making things hard when bugs show up.We had a bad experience when we discovered some issues while writing use-herald-action and since then we moved to
esbuild.esbuild is also faster, and it only produces the bundle as a single file, instead of doing what ncc does today (it even pulls some tests types that are not needed)