Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing type issue introduced by commander fix #179

Merged
merged 2 commits into from
Jan 22, 2021

Conversation

gagoar
Copy link
Owner

@gagoar gagoar commented Jan 22, 2021

Description

When landing the commander v7 changes, turns out the types didn't match anymore with the new option added groupSourceComments

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #179 (25753f4) into master (b79e346) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #179   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          216       227   +11     
  Branches        36        40    +4     
=========================================
+ Hits           216       227   +11     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/getCustomConfiguration.ts 100.00% <ø> (ø)
src/utils/getGlobalOptions.ts 100.00% <ø> (ø)
src/commands/generate.ts 100.00% <100.00%> (ø)
src/utils/codeowners.ts 100.00% <100.00%> (ø)
src/utils/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98df49c...25753f4. Read the comment docs.

@gagoar gagoar merged commit 1909a63 into master Jan 22, 2021
@gagoar gagoar deleted the gg/fixing-type-issue-introduce-by-commander-fix branch January 22, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant