Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos of --use-maintainers flag in readme #171

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

gustavkj
Copy link
Collaborator

@gustavkj gustavkj commented Jan 21, 2021

Fixes three typos of the --use-maintainers flag in the readme. Maybe it works in both cases, but it seems to be a typo since it's written with kebab case in the cli code:

.option(
'--use-maintainers',
'For every package.json found, generate a CODEOWNERS entry using the maintainers field',
false

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #171 (9c39c7f) into master (e86aae2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #171   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          202       202           
  Branches        31        31           
=========================================
  Hits           202       202           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e86aae2...9c39c7f. Read the comment docs.

@coveralls
Copy link
Collaborator

coveralls commented Jan 21, 2021

Pull Request Test Coverage Report for Build 501980714

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 499955588: 0.0%
Covered Lines: 197
Relevant Lines: 197

💛 - Coveralls

@gustavkj gustavkj force-pushed the fix-typo-in-use-maintainers-flag branch from c748093 to a50fe87 Compare January 21, 2021 19:27
@gustavkj gustavkj force-pushed the fix-typo-in-use-maintainers-flag branch from a50fe87 to 9c39c7f Compare January 21, 2021 19:28
@gagoar
Copy link
Owner

gagoar commented Jan 21, 2021

More than a typo, is that when the cli translates that into a variable becomes camelCase instead of kebab.

still correct to make it kebab

@gagoar gagoar merged commit 2fa3a66 into gagoar:master Jan 21, 2021
@gustavkj gustavkj deleted the fix-typo-in-use-maintainers-flag branch November 15, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants