Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] --use-root-maintainers flag not available in latest release #344

Closed
alexlo03 opened this issue Mar 15, 2023 · 6 comments · Fixed by #345
Closed

[BUG] --use-root-maintainers flag not available in latest release #344

alexlo03 opened this issue Mar 15, 2023 · 6 comments · Fixed by #345
Assignees
Labels
bug Something isn't working

Comments

@alexlo03
Copy link

Describe the bug
--use-root-maintainers flag not available in latest release

To Reproduce

$ codeowners-generator generate -h
Usage: codeowners-generator generate [options]

Generates a topLevel file containing the paths of all the nested CODEOWNERS

Options:
  --use-maintainers              For every package.json found, generate a
                                 CODEOWNERS entry using the maintainers field
                                 (default: false)
  --group-source-comments        Instead of generating one comment per rule,
                                 enabling this flag will group them, reducing
                                 comments to one per source file. Useful if
                                 your codeowners file gets too noisy (default:
                                 false)
  --custom-regeneration-command  Specify a custom regeneration command to be
                                 printed in the generated CODEOWNERS file, it
                                 should be mapped to run codeowners-generator
  --output [output file]         The output path and name of the file,
                                 (default: CODEOWNERS)
  -h, --help                     display help for command

$ codeowners-generator -V
2.1.4

$ codeowners-generator generate --use-root-maintainers true
error: unknown option '--use-root-maintainers'

Expected behavior

https://github.com/gagoar/codeowners-generator#cli-options

Hard to tell what happened? Seems like it should be there based on

#330
#331

@alexlo03 alexlo03 added the bug Something isn't working label Mar 15, 2023
@alexlo03
Copy link
Author

Note the feature works when configured from package.json

@gagoar
Copy link
Owner

gagoar commented Mar 15, 2023

right. So the functionality is implemented but not surfaced inside the cli: https://github.com/gagoar/codeowners-generator/blob/master/src/bin/cli.ts

@gagoar
Copy link
Owner

gagoar commented Mar 15, 2023

the cli is just a tiny layer on top of the logic so that's where the issue is. I will address this today. In the mean time please use the other ways to configure it so you can get unstuck!

@gagoar gagoar self-assigned this Mar 15, 2023
gagoar added a commit that referenced this issue Mar 19, 2023
It was reported that `--use-root-maintainers` is not explicitly
available via the CLI.

This PR should solved that, and close #344
@gagoar
Copy link
Owner

gagoar commented Mar 19, 2023

Hey @alexlo03 Please take a look at the new version 2.1.5 that should bring the option to the CLI. Thank you again for reporting the bug ❤️

@alexlo03
Copy link
Author

Thanks!

@alexlo03
Copy link
Author

Oh, and validated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants