You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Right now, a comment (e.g. # Rule extracted from dir1/CODEOWNERS) is added before every rule in the generated CODEOWNERS file. This is quite noisy.
# Rule extracted from dir1/CODEOWNERS
/dir1/**/README.md @miny
# Rule extracted from dir1/CODEOWNERS
/dir1/README.md @moe
# Rule extracted from dir2/CODEOWNERS
/dir2/**/*.ts @moe
# Rule extracted from dir2/CODEOWNERS
/dir2/dir3/*.ts @miny
Describe the solution you'd like
I suggest having one comment before each collection or rules from each file.
The example above would then be:
# Rule(s) extracted from dir1/CODEOWNERS
/dir1/**/README.md @miny
/dir1/README.md @moe
# Rule(s) extracted from dir2/CODEOWNERS
/dir2/**/*.ts @moe
/dir2/dir3/*.ts @miny
Describe alternatives you've considered
I haven't considered any other solutions for this.
Additional context
I can help fix this. But adding issue for discussion and track keeping.
The text was updated successfully, but these errors were encountered:
good idea @gustavkj we didn't do it because we have very big nested codeowners and ppl was losing track of what was going on. I will consider this added as a feature in the configuration, thoughts? groupSourceComments: true or something to that effect.
## Description
This PR addresses the requested feature in (closes#164) by @gustavkj
the option is `groupSourceComments` or `--group-source-comments` when used in the cli.
It will avoid adding a comment per rule found and instead will group the comment per source.
Is your feature request related to a problem? Please describe.
Right now, a comment (e.g.
# Rule extracted from dir1/CODEOWNERS
) is added before every rule in the generated CODEOWNERS file. This is quite noisy.Describe the solution you'd like
I suggest having one comment before each collection or rules from each file.
The example above would then be:
Describe alternatives you've considered
I haven't considered any other solutions for this.
Additional context
I can help fix this. But adding issue for discussion and track keeping.
The text was updated successfully, but these errors were encountered: