Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable RHL in production, and when HMR not enabled #863

Merged
merged 1 commit into from
Feb 18, 2018

Conversation

theKashey
Copy link
Collaborator

No description provided.

@gregberge
Copy link
Collaborator

@theKashey I guess this is what broke SSR right?

@gregberge gregberge merged commit ffe0035 into next Feb 18, 2018
@gregberge gregberge deleted the need-for-module-hot branch February 18, 2018 21:32
@codecov-io
Copy link

Codecov Report

Merging #863 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #863   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files          30       30           
  Lines         622      622           
  Branches      147      147           
=======================================
  Hits          541      541           
  Misses         65       65           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 572e803...de9864f. Read the comment docs.

@theKashey
Copy link
Collaborator Author

May be. The SSR example, I’ve written was ok even without patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants