Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more bugs #857

Merged
merged 8 commits into from
Feb 16, 2018
Merged

No more bugs #857

merged 8 commits into from
Feb 16, 2018

Conversation

theKashey
Copy link
Collaborator

Fixes 2 bugs
Improves one case (typeScript)
Adds one case (SSR)

@neoziro, I could not reproduce #854 - is it fine for me.

@joshjg
Copy link

joshjg commented Feb 13, 2018

Fixes the error I was seeing, but the end result (for me) is the same - the async child does not update

@codecov-io
Copy link

codecov-io commented Feb 14, 2018

Codecov Report

Merging #857 into next will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #857      +/-   ##
==========================================
+ Coverage   86.86%   86.97%   +0.11%     
==========================================
  Files          30       30              
  Lines         609      622      +13     
  Branches      145      147       +2     
==========================================
+ Hits          529      541      +12     
  Misses         65       65              
- Partials       15       16       +1
Impacted Files Coverage Δ
src/reconciler/index.js 100% <ø> (ø) ⬆️
src/proxy/createClassProxy.js 98.88% <100%> (+0.06%) ⬆️
src/proxy/constants.js 100% <100%> (ø) ⬆️
src/reconciler/hotReplacementRender.js 84.61% <100%> (-0.6%) ⬇️
src/reconciler/proxyAdapter.js 100% <100%> (ø) ⬆️
src/global/generation.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99da77b...e000cb8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants