Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate overridden members #837

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Regenerate overridden members #837

merged 1 commit into from
Feb 1, 2018

Conversation

theKashey
Copy link
Collaborator

During HOT stand-in compares the old class and the new one.
It created 2 instances and checking what was changed in class creation.
If something did - it will inject changed value into the real instances. Thus the arrow function update work.

But, in case of ES6 RHL could not change the constructor, as a result it always compares the "first" version and the last one. Thus - it will not inject "not changed" method.... keeping the previously injected variant.

This PR just fixes this moment, and checking also injected values, and fixes #836

@codecov-io
Copy link

codecov-io commented Feb 1, 2018

Codecov Report

Merging #837 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           next   #837   +/-   ##
===================================
  Coverage    85%    85%           
===================================
  Files        23     23           
  Lines       507    507           
  Branches    144    139    -5     
===================================
  Hits        431    431           
- Misses       56     63    +7     
+ Partials     20     13    -7
Impacted Files Coverage Δ
packages/react-hot-loader/src/global/modules.js 74.19% <0%> (ø) ⬆️
...ot-loader/src/internal/stack/hydrateLegacyStack.js 8.69% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d72a9dd...353e182. Read the comment docs.

@gregberge gregberge merged commit 39d4f5b into next Feb 1, 2018
@gregberge gregberge deleted the fix-arrow-methods branch February 1, 2018 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants