fix: do not update hooks while updating hooks, fixes #1294

gaearon · Jul 10, 2019 · afa8ed4 · afa8ed4
1 parent b0ee8db
commit afa8ed4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/proxy/createClassProxy.js b/src/proxy/createClassProxy.js
@@ -341,13 +341,13 @@ function createClassProxy(InitialComponent, proxyKey, options = {}) {
     }
 
     if (NextComponent === CurrentComponent) {
-      return;
+      return false;
     }
 
     // Prevent proxy cycles
     const existingProxy = proxies.get(NextComponent);
     if (existingProxy) {
-      return;
+      return false;
     }
 
     isFunctionalComponent = !isReactClass(NextComponent);
@@ -412,6 +412,8 @@ function createClassProxy(InitialComponent, proxyKey, options = {}) {
         classUpdatePostponed = classHotReplacement;
       }
     }
+
+    return true;
   }
 
   update(InitialComponent);

diff --git a/src/reconciler/proxies.js b/src/reconciler/proxies.js
@@ -57,8 +57,7 @@ export const updateProxyById = (id, type, options = {}) => {
       id,
       merge({}, renderOptions, { proxy: componentOptions.get(type) || {} }, options),
     );
-  } else {
-    proxiesByID[id].update(type);
+  } else if (proxiesByID[id].update(type)) {
     // proxy could be registered again only in case of HMR
     incrementHotGeneration();
   }