Skip to content
This repository has been archived by the owner on Apr 9, 2020. It is now read-only.

Explore wrapping HOCs at the call site #18

Closed
gaearon opened this issue Sep 12, 2015 · 4 comments
Closed

Explore wrapping HOCs at the call site #18

gaearon opened this issue Sep 12, 2015 · 4 comments

Comments

@gaearon
Copy link
Owner

gaearon commented Sep 12, 2015

While this sounds pretty crazy, we might want to (via opt-in API?) signal that a particular function in a particular module produces a component, so that the results of this function are identified as components at the call site.

On the other hand maybe this is a terrible idea.

@kgdev
Copy link

kgdev commented Jan 20, 2016

Any updates?

@gaearon
Copy link
Owner Author

gaearon commented Mar 5, 2016

Nah, this would be weird. #26 is a better solution to the same problem.

@gaearon gaearon closed this as completed Mar 5, 2016
@gaearon
Copy link
Owner Author

gaearon commented Apr 18, 2016

This is fixed in React Hot Loader 3.
It is built with lessons learned from both React Hot Loader and React Transform.
It’s still in alpha but I encourage you to check it out!

@gaearon
Copy link
Owner Author

gaearon commented Apr 18, 2016

Nah, this would be weird.

Weird or not, this is exactly how we solved it. 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants