-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(validation): updated upgradeDowngradeHistory Grades #684
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #684 +/- ##
=======================================
Coverage 93.05% 93.05%
=======================================
Files 25 25
Lines 662 662
Branches 225 225
=======================================
Hits 616 616
Misses 46 46 ☔ View full report in Codecov by Sentry. |
Awesome! Thanks, @z3nful, for another one of these 🙏 Noted the "Not a typo, how it was returned from API" 😂 Yahoo 🤷♂️ I'm assuming the Otherwise looks great and thanks as usual! |
Np : ) I just added the note to the other 2 as well. It seems like 'SEll' could logically also be returned at some point, but I checked that module against 10k different stocks and its possible that these typos are just years old and have had some type of validation built in since then on Yahoos side. |
Awesome, thanks so much! 🙏 Yeah a big part of the validation is basically crowdsourcing community knowledge around weird API responses and this is certainly one of them! And the typescript integration makes this so great... the compiler will now warn people if they accidentally correctly spell these things and help them spell it in a way will keep their code working as expected! |
🎉 This PR is included in version 2.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
Type
Comments/notes