Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secFilings validation error #261

Closed
nicogenz opened this issue Aug 14, 2021 · 2 comments
Closed

secFilings validation error #261

nicogenz opened this issue Aug 14, 2021 · 2 comments
Labels
bug Something isn't working validation Issues related to validation

Comments

@nicogenz
Copy link
Contributor

Validation Error

Minimal Reproduction

await yahooFinance.quoteSummary('AAPL', { modules: ['secFilings'] })

Symbol(s) that it happened for

  • AAPL
  • AMZN
  • GOOGL
  • ... tried several and it looks like it is failing for all symbols

Error Message

The following result did not validate with schema: #/definitions/QuoteSummaryResult
[
  {
    instancePath: '/secFilings/filings/0',
    schemaPath: '#/required',
    keyword: 'required',
    params: { missingProperty: 'url' },
    message: "must have required property 'url'",
    data: {
      date: '2021-07-30',
      epochDate: 2021-07-30T11:04:38.000Z,
      type: '10-Q',
      title: 'Quarterly Report',
      edgarUrl: 'https://yahoo.brand.edgar-online.com/DisplayFiling.aspx?TabIndex=2&dcn=0001018724-21-000020&nav=1&src=Yahoo',
      maxAge: 1
    }
  },
  {
    instancePath: '/secFilings/filings/1',
    schemaPath: '#/required',
    keyword: 'required',
    params: { missingProperty: 'url' },
    message: "must have required property 'url'",
    data: {
      date: '2021-07-29',
      epochDate: 2021-07-29T21:39:06.000Z,
      type: '8-K',
      title: 'Results of Operations and Financial Condition, Financial Statements and Exhibits',
      edgarUrl: 'https://yahoo.brand.edgar-online.com/DisplayFiling.aspx?TabIndex=2&dcn=0001018724-21-000018&nav=1&src=Yahoo',
      maxAge: 1
    }
  },
  ...

Environment

Browser or Node: Node
Node version (if applicable): v14.17.4
Npm version: 6.14.14
Browser verion (if applicable):
Library version (e.g. 1.10.1): 1.14.4

Information

Looks like yahoo changed the API, because the issue exists for several symbols like AAPL, AMZN, GOOGL.

@nicogenz nicogenz added bug Something isn't working validation Issues related to validation labels Aug 14, 2021
@nicogenz
Copy link
Contributor Author

This error seems to no longer exists so i close this issue now.
I also documented a example response for symbol "AAPL" via #315

@gadicc
Copy link
Owner

gadicc commented Oct 24, 2021

Ah, amazing, thanks for following up! Was catching up on PRs first, then plan to go through issues next 😅

Looks like I fixed this in 5657df7#diff-f09b16e4a2f6c1013d12e0f74ba9781a48dd6e00f3ebf938fc065d718cfc01c3R732 when fixing #295.

Thanks for the extra docs too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validation Issues related to validation
Projects
None yet
Development

No branches or pull requests

2 participants