You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we can override defaults per request.
But's a bit weird for things like the queue, which affects all past and future requests too.
Potential Example Usage
// with run-time validationyahooFinance.setConfig({ ... });// perhaps to be clearer about what's a default for future requestsyahooFinance.setDefault({});
Docs to explain difference between global options and global defaults? (e.g. queue opts are global opts, but maybe we have some fetch opts that are defaults used for each request and can be overriden)
Change behaviour in yf.* funcs that any overrides should be just for that call, and should throw an error if trying to override a global option (like the queue, this isn't really make sense, as there is only one queue for all requests). NB: this WOULD be a breaking change but since the queue code is still only in devel and has not been released, we're all good!
The text was updated successfully, but these errors were encountered:
Would it make more sense to override the default config, or just merge them? I would go with merging, as it is usually a more predictable behavior. What do you think, @gadicc?
Feature Request
Wanted Feature
A recommended method to set global defaults.
Use Cases
Currently we can override defaults per request.
But's a bit weird for things like the queue, which affects all past and future requests too.
Potential Example Usage
Timeline
_opts
yf.*
funcs that any overrides should be just for that call, and should throw an error if trying to override a global option (like the queue, this isn't really make sense, as there is only one queue for all requests). NB: this WOULD be a breaking change but since the queue code is still only in devel and has not been released, we're all good!The text was updated successfully, but these errors were encountered: