-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(yahoo): YF_QUERY_HOST in URLs (user configurable, default query2) #109
Conversation
May also be better to just have a default single YF_QUERY_HOST and let the user change it as desired, rather than picking randomly on every request, which could make it harder to find errors if one host starts acting up. |
Codecov Report
@@ Coverage Diff @@
## devel #109 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 461 468 +7
Branches 146 150 +4
=========================================
+ Hits 461 468 +7
Continue to review full report at Codecov.
|
|
grep -l query1 tests/http/*.json \ | xargs sed -i 's/query1.finance.yahoo.com/query2.finance.yahoo.com/g'
# [2.3.0](v2.2.0...v2.3.0) (2022-03-06) ### Bug Fixes * **insights:** fix schema for more recent yahoo results ([c71a400](c71a400)) * **validation:** Date, allow ISODate without ms precision too ([82ba1cb](82ba1cb)) ### Features * **yahoo:** Configurable YF_QUERY_HOST in URLs ([#109](#109)) ([716c0f1](716c0f1))
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Just a note here, in the end, I didn't randomize the host, because:
Ref #426. |
Closes #95.
Closes #426.
Maybe a WIP for #95 or perhaps full first part of it that we could merge now.
https://${YF_QUERY_HOST}/blah
${query}
yahooFinanceFetch
: do variable substitution, randomly picking betweenquery1
/query2
fetchDevel
: standardize toquery2
for cachequery2
in all existingtests/http
files (query1
was much less common)