Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exporting types #15

Open
Kyriakos-Bekas opened this issue Mar 9, 2023 · 0 comments
Open

Support exporting types #15

Kyriakos-Bekas opened this issue Mar 9, 2023 · 0 comments

Comments

@Kyriakos-Bekas
Copy link

I am using this package with TypeScript and Vite.
Vite does not support require, so I want to import the module with ES import as shown below.

import docusaurusPluginImageZoom from 'docusaurus-plugin-image-zoom';

This line, however, has TypeScript yield the following

Could not find a declaration file for module 'docusaurus-plugin-image-zoom'.
'<redacted>/node_modules/docusaurus-plugin-image-zoom/src/index.js' implicitly has an 'any' type.

I acknowledge that the package is written in plain JS and is therefore not exporting any types, but I believe this is a feature that could reduce bugs, improve the workflow of implementing fixes also enable more contributions.

I would personally consider helping with the transition to TypeScript.

Thanks for your effort and time and great job by the way!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant