Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Cargo.lock to repository #13

Closed
ElysaSrc opened this issue Nov 6, 2023 · 2 comments
Closed

Adding Cargo.lock to repository #13

ElysaSrc opened this issue Nov 6, 2023 · 2 comments

Comments

@ElysaSrc
Copy link

ElysaSrc commented Nov 6, 2023

Hello,

I'm trying to package Satty for NixOS, but it requires the Cargo.lock file.
As the documentation says:

If you’re building a non-end product, such as a rust library that other rust packages will depend on, put Cargo.lock in your .gitignore. If you’re building an end product, which are executable like command-line tool or an application, or a system library with crate-type of staticlib or cdylib, check Cargo.lock into git. If you’re curious about why that is, see “Why do binaries have Cargo.lock in version control, but not libraries?” in the FAQ.

(Source: https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html)

If I'm understing this correctly we fall under the case on which we should have a Cargo.lock commited.

Once you make a release with this file I'll be happy to package it for NixOS.

@gabm
Copy link
Owner

gabm commented Nov 6, 2023

Thanks for volunteering to bring Satty to Nix, highly appreciated.

I will make sure to include a Cargo.lock in the next release!

@gabm
Copy link
Owner

gabm commented Nov 7, 2023

@gabm gabm closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants