Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdlog 1.11.0 fails to build with libfmt 10.0.0 #2788

Closed
setoye opened this issue Jun 30, 2023 · 1 comment
Closed

spdlog 1.11.0 fails to build with libfmt 10.0.0 #2788

setoye opened this issue Jun 30, 2023 · 1 comment

Comments

@setoye
Copy link

setoye commented Jun 30, 2023

in common.h line 168:

// clang doesn't like SFINAE disabled constructor in std::is_convertible<> so have to repeat the condition from basic_format_string here,
// in addition, fmt::basic_runtime<Char> is only convertible to basic_format_string<Char> but not basic_string_view<Char>
template<class T, class Char = char>
struct is_convertible_to_basic_format_string
    : std::integral_constant<bool,
          std::is_convertible<T, fmt::basic_string_view<Char>>::value || std::is_same<remove_cvref_t<T>, fmt::basic_runtime<Char>>::value>
{};

looks like fmt::basic_runtime has been renamed into fmt::runtime_format_string.

@tt4g
Copy link
Contributor

tt4g commented Jun 30, 2023

spdlog v1.11.0 doesn't support fmt 10.
v1.x branch supported by 0ca574a, wait for next release or use v1.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants